Fix multipleOf with integer-valued float for large integers - #1459
Open
worksbyfriday wants to merge 1 commit into
Open
worksbyfriday wants to merge 1 commit into
worksbyfriday wants to merge 1 commit into
Conversation
When multipleOf is a float with an integer value (e.g. 11.0), convert it to int before performing the check. This avoids floating-point precision loss for instances beyond 2**53, where float division produces incorrect results. Per JSON Schema spec, numbers with zero fractional parts are integers. Fixes python-jsonschema#1159
Julian
added
the
Needs Test Upstream
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
multipleOfis an integer-valued float (e.g.11.0), the validator uses float division, which loses precision for instances beyond2**53. This causes false negatives:9007199254740995is a multiple of11, but9007199254740995 / 11.0loses precision and the check fails.The fix converts integer-valued floats to
intbefore performing the divisibility check, usingfloat.is_integer(). This ensures thatmultipleOf: 11.0behaves identically tomultipleOf: 11, per the JSON Schema spec which states that numbers with zero fractional parts are integers.Non-integer floats (e.g.
0.5) are unaffected — theisinstance(dB, float)branch still handles them.Fixes #1159.